Compile fix for Leap 15.0 (related to bsc#1130502) #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lslezak
commented
Apr 18, 2019
lslezak
commented
- Similar to Compile fix for Leap 15.0 (related to bsc#1130502) libyui-qt#106
- 2.46.2
Vogtinator
reviewed
May 3, 2019
| @@ -180,7 +181,11 @@ QSize | |||
| YQPkgDiskUsageList::sizeHint() const | |||
| { | |||
| QFontMetrics fms( font() ); | |||
| #if QT_VERSION >= 0x051100 | |||
There was a problem hiding this comment.
That's hex - it would be Qt 5.17. Use #if QT_VERSION >= QT_VERSION_CHECK(5, 11, 0) instead
There was a problem hiding this comment.
Right. Changing in both places with new PRs.
That was a nasty one: This had worked all the time until Qt went for double-digit minor versions (starting with Qt 5.10). Argh. ;-(
mvidner
pushed a commit
to mvidner/libyui-combined-alpha-3
that referenced
this pull request
Jan 15, 2021
Compile fix for Leap 15.0 (related to bsc#1130502)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.